fix(zc): save select screen not showing new hp after save->reset

Author: connorjclark

src/zc/saves.cpp

@@ -41,12 +41,18 @@ static int currgame = -1;
 static std::vector<save_t> saves;
 static bool save_current_replay_games;
 
-save_t::~save_t()
+void save_t::unload()
 {
 	if (this->game)
 		delete this->game;
 	else
 		delete this->header;
+	this->game = nullptr;
+	this->header = nullptr;
+}
+save_t::~save_t()
+{
+	unload();
 }
 
 static fs::path get_legacy_save_file_path()
@@ -2008,6 +2014,18 @@ void saves_unselect()
 	currgame = -1;
 }
 
+void saves_unload(int32_t index)
+{
+	if (index == -1)
+		return;
+
+	auto& save = saves[index];
+	save.unload();
+
+	if (currgame == index)
+		currgame = -1;
+}
+
 int32_t saves_count()
 {
 	return saves.size();

src/zc/saves.h

@@ -35,13 +35,15 @@ struct save_t
 	save_t(const save_t&) = delete;
 	save_t& operator=(const save_t&) = delete;
 	~save_t();
+	void unload();
 };
 
 int32_t saves_init();
 int32_t saves_load();
 int32_t saves_write();
 bool saves_select(int32_t index);
 void saves_unselect();
+void saves_unload(int32_t index);
 int32_t saves_count();
 int32_t saves_current_selection();
 bool saves_create_slot(gamedata* game, bool write_to_disk = true);

src/zc/title.cpp

@@ -1446,8 +1446,10 @@ void titlescreen(int32_t lsave)
 	}
 
 	if (saves_current_selection() != -1)
+	{
 		last_slot_pos = saves_current_selection() % 3;
-	saves_unselect();
+		saves_unload(saves_current_selection());
+	}
 
 	if (replay_get_mode() == ReplayMode::Record)
 	{