fix(zc): set previously unset save_t write_to_disk in all places

Author: connorjclark

src/zc/saves.cpp

@@ -2121,13 +2121,14 @@ bool saves_create_slot(gamedata* game, bool write_to_disk)
 	return true;
 }
 
-bool saves_create_slot(fs::path path)
+bool saves_create_slot(fs::path path, bool write_to_disk)
 {
 	if (!fs::exists(path))
 		return false;
 
 	auto& save = saves.emplace_back();
 	save.path = path;
+	save.write_to_disk = write_to_disk;
 	return true;
 }
 

src/zc/saves.h

@@ -10,7 +10,7 @@ namespace fs = std::filesystem;
 struct save_t
 {
 	fs::path path;
-	bool write_to_disk;
+	bool write_to_disk = true;
 	// If loaded is false, this is null.
 	// If loaded is true and `game` is null, this memory is owned by save_t.
 	// If loaded is true and `game` is not null, this points to the header field in `game`.
@@ -45,7 +45,7 @@ void saves_unselect();
 int32_t saves_count();
 int32_t saves_current_selection();
 bool saves_create_slot(gamedata* game, bool write_to_disk = true);
-bool saves_create_slot(fs::path path);
+bool saves_create_slot(fs::path path, bool write_to_disk = true);
 bool saves_is_slot_loaded(int32_t index, bool full_data = false);
 const save_t* saves_get_slot(int32_t index, bool full_data = false);
 const save_t* saves_get_current_slot();

src/zc/zelda.cpp

@@ -5141,7 +5141,7 @@ int main(int argc, char **argv)
 		if (replay_is_active() && replay_get_meta_str("sav").size())
 		{
 			auto save_path = replay_get_replay_path().parent_path() / replay_get_meta_str("sav");
-			bool success = saves_create_slot(save_path);
+			bool success = saves_create_slot(save_path, false);
 			if (!success)
 				Z_error_fatal("Failed to load replay's save file");
 		}