refactor: remove scary and now pointless warnings when toggling fullscreen

Author: connorjclark

src/zc/zc_sys.cpp

@@ -7667,9 +7667,23 @@ int32_t onExtLetterGridEntry()
 static BITMAP* oldscreen;
 int32_t onFullscreenMenu()
 {
-	onFullscreen();
+	PALETTE oldpal;
+	get_palette(oldpal);
+
+	fullscreen = !fullscreen;
+	all_toggle_fullscreen(fullscreen);
+	zc_set_config("zeldadx","fullscreen",fullscreen);
+
+	zc_set_palette(oldpal);
+	gui_mouse_focus=0;
+	extern int32_t switch_type;
+	switch_type = pause_in_background ? SWITCH_PAUSE : SWITCH_BACKGROUND;
+	set_display_switch_mode(fullscreen?SWITCH_BACKAMNESIA:switch_type);
+	set_display_switch_callback(SWITCH_OUT, switch_out_callback);
+	set_display_switch_callback(SWITCH_IN, switch_in_callback);
 	misc_menu.select_uid(MENUID_MISC_FULLSCREEN, isFullScreen());
 	misc_menu.select_uid(MENUID_MISC_VIDMODE, isFullScreen());
+
 	return D_O_K;
 }
 

src/zc/zelda.cpp

@@ -3995,40 +3995,6 @@ int32_t isFullScreen()
     return !is_windowed_mode();
 }
 
-int32_t onFullscreen()
-{
-	if(jwin_alert3(
-			(is_windowed_mode()) ? "Fullscreen Warning" : "Change to Windowed Mode", 
-			(is_windowed_mode()) ? "Some video chipsets/drivers do not support 8-bit native fullscreen" : "Proceeding will drop from Fullscreen to Windowed Mode", 
-			(is_windowed_mode()) ? "We strongly advise saving your game before shifting from windowed to fullscreen!": "Do you wish to shift from Fullscreen to Windowed mode?",
-			(is_windowed_mode()) ? "Do you wish to continue to fullscreen mode?" : NULL,
-		 "&Yes", 
-		"&No", 
-		NULL, 
-		'y', 
-		'n', 
-		0, 
-		get_zc_font(font_lfont)) == 1)	
-    {
-	    PALETTE oldpal;
-	    get_palette(oldpal);
-	    
-	    fullscreen = !fullscreen;
-		all_toggle_fullscreen(fullscreen);
-		zc_set_config("zeldadx","fullscreen",fullscreen);
-	    
-	    zc_set_palette(oldpal);
-	    gui_mouse_focus=0;
-	    switch_type = pause_in_background ? SWITCH_PAUSE : SWITCH_BACKGROUND;
-	    set_display_switch_mode(fullscreen?SWITCH_BACKAMNESIA:switch_type);
-		set_display_switch_callback(SWITCH_OUT, switch_out_callback);
-		set_display_switch_callback(SWITCH_IN, switch_in_callback);
-
-	    return D_REDRAW;
-    }
-    else return D_O_K;
-}
-
 static bool current_session_is_replay = false;
 static void load_replay_file(ReplayMode mode, std::string replay_file, int frame)
 {

src/zc/zelda.h

@@ -28,7 +28,6 @@ struct itemdata;
 struct MsgStr;
 
 int32_t isFullScreen();
-int32_t onFullscreen();
 extern bool zqtesting_mode;
 extern bool use_testingst_start;
 

src/zq/zquest.cpp

@@ -1573,36 +1573,21 @@ int32_t onResetTransparency()
 
 int32_t onFullScreen()
 {
-	if(jwin_alert3(
-			(is_windowed_mode()) ? "Fullscreen Warning" : "Change to Windowed Mode", 
-			(is_windowed_mode()) ? "Some video chipsets/drivers do not support 8-bit native fullscreen" : "Proceeding will drop from Fullscreen to Windowed Mode", 
-			(is_windowed_mode()) ? "We strongly advise saving your quest before shifting from windowed to fullscreen!": "Do you wish to shift from Fullscreen to Windowed mode?",
-			(is_windowed_mode()) ? "Do you wish to continue to fullscreen mode?" : NULL,
-		 "&Yes", 
-		"&No", 
-		NULL, 
-		'y', 
-		'n', 
-		0, 
-		get_zc_font(font_lfont)) == 1)	
-	{
-		get_palette(RAMpal);
-		bool windowed=is_windowed_mode()!=0;
-		all_toggle_fullscreen(windowed);
-		
-		gui_mouse_focus=0;
-		gui_bg_color=jwin_pal[jcBOX];
-		gui_fg_color=jwin_pal[jcBOXFG];
-		MouseSprite::set(ZQM_NORMAL);
-		zc_set_palette(RAMpal);
-		position_mouse(zq_screen_w/2,zq_screen_h/2);
-		set_display_switch_mode(SWITCH_BACKGROUND);
-		set_display_switch_callback(SWITCH_OUT, switch_out);
-		set_display_switch_callback(SWITCH_IN, switch_in);
-		zc_set_config("zquest","fullscreen", is_windowed_mode() ? 0 : 1);
-		return D_REDRAW;
-	}
-	else return D_O_K;
+	get_palette(RAMpal);
+	bool windowed=is_windowed_mode()!=0;
+	all_toggle_fullscreen(windowed);
+
+	gui_mouse_focus=0;
+	gui_bg_color=jwin_pal[jcBOX];
+	gui_fg_color=jwin_pal[jcBOXFG];
+	MouseSprite::set(ZQM_NORMAL);
+	zc_set_palette(RAMpal);
+	position_mouse(zq_screen_w/2,zq_screen_h/2);
+	set_display_switch_mode(SWITCH_BACKGROUND);
+	set_display_switch_callback(SWITCH_OUT, switch_out);
+	set_display_switch_callback(SWITCH_IN, switch_in);
+	zc_set_config("zquest","fullscreen", is_windowed_mode() ? 0 : 1);
+	return D_REDRAW;
 }
 
 int32_t onEnter()