fix: OpenAI-compatible legacy tool_call XML and inflight stream snapshots#72
Merged
Merged
Conversation
Parse <tool_call> blocks in assistant text from some OpenAI-compatible gateways (e.g. Xiaomi) so Agent mode executes tools and Ask mode no longer shows raw XML. Preserve per-thread streaming drafts when switching threads during an in-flight IPC stream. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<tool_call>XML in assistant text for OpenAI-compatible gateways (e.g. Xiaomi) so Agent mode can execute tools instead of stopping after plain text.Fixes #71.
Test plan
<tool_call>in the final message.npm test—legacyToolCallFromText,streamInflightSnapshot,threadReloadSkipMade with Cursor