Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some old problems #1

Open
wants to merge 4 commits into
base: master
from

Conversation

@TheHllm
Copy link

commented Sep 2, 2019

No description provided.

@Zaczero
Copy link
Owner

left a comment

0516643
This commit seems unnecessary. I can agree with you being added to the Authors but the rest should be left as is. I'll update the version number whenever it's a good time to post an update to NuGet =)

[JsonProperty(PropertyName = "subject")]
public string Subject { get; set; }
[JsonProperty(PropertyName = "datetime")]
public string Datetime { get; set; }

This comment has been minimized.

Copy link
@Zaczero

Zaczero Sep 2, 2019

Owner

Naming is a little inconsistent. Some properties are named DateTime and some Datetime. It would be nice if you could rename all of them to DateTime style.

Suggested change
public string Datetime { get; set; }
public string DateTime { get; set; }
[JsonProperty(PropertyName = "datetime")]
public string Datetime { get; set; }
[JsonProperty(PropertyName = "datetime2")]
public string Datetime2 { get; set; }

This comment has been minimized.

Copy link
@Zaczero

Zaczero Sep 2, 2019

Owner
Suggested change
public string Datetime2 { get; set; }
public string DateTime2 { get; set; }
[JsonProperty(PropertyName = "subject")]
public string Subject { get; set; }
[JsonProperty(PropertyName = "datetime")]
public string Datetime { get; set; }

This comment has been minimized.

Copy link
@Zaczero

Zaczero Sep 2, 2019

Owner
Suggested change
public string Datetime { get; set; }
public string DateTime { get; set; }
[JsonProperty(PropertyName = "datetime2")]
public string DateTime2 { get; set; }
[JsonProperty(PropertyName = "timeago")]
public int Timeago { get; set; }

This comment has been minimized.

Copy link
@Zaczero

Zaczero Sep 2, 2019

Owner
Suggested change
public int Timeago { get; set; }
public int TimeAgo { get; set; }
[JsonProperty(PropertyName = "mail_get_time")]
public int GetTime;
[JsonProperty(PropertyName = "mail_get_duetime")]
public int Duetime { get; set; }

This comment has been minimized.

Copy link
@Zaczero

Zaczero Sep 2, 2019

Owner
Suggested change
public int Duetime { get; set; }
public int DueTime { get; set; }

@Zaczero Zaczero added the enhancement label Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.