feat(app-toolkit): Remove all legacy helpers (#2089)

src/app-toolkit/app-toolkit.interface.ts

@@ -15,8 +15,6 @@ import {
 import { BaseToken } from '~position/token.interface';
 import { Network } from '~types/network.interface';
 
-import { AppToolkitHelperRegistry } from './app-toolkit.helpers';
-
 export const APP_TOOLKIT = Symbol('APP_TOOLKIT');
 
 export interface IAppToolkit {
@@ -65,7 +63,5 @@ export interface IAppToolkit {
 
   // Global Helpers
 
-  get helpers(): AppToolkitHelperRegistry;
-
   getBigNumber(source: BigNumberJS.Value | ethers.BigNumber): BigNumberJS;
 }

src/app-toolkit/app-toolkit.module.ts

@@ -6,13 +6,12 @@ import { NetworkProviderModule } from '~network-provider/network-provider.module
 import { PositionModule } from '~position/position.module';
 import { TokenModule } from '~token/token.module';
 
-import { AppToolkitHelperRegistry, AppToolkitHelpers } from './app-toolkit.helpers';
 import { APP_TOOLKIT } from './app-toolkit.interface';
 import { AppToolkit } from './app-toolkit.service';
 
 @Module({
   imports: [NetworkProviderModule, TokenModule, PositionModule, MulticallModule, AppModule],
-  providers: [{ provide: APP_TOOLKIT, useClass: AppToolkit }, AppToolkitHelperRegistry, ...AppToolkitHelpers],
-  exports: [APP_TOOLKIT, ...AppToolkitHelpers],
+  providers: [{ provide: APP_TOOLKIT, useClass: AppToolkit }],
+  exports: [APP_TOOLKIT],
 })
 export class AppToolkitModule {}

src/app-toolkit/app-toolkit.service.ts

@@ -1,4 +1,4 @@
-import { CACHE_MANAGER, forwardRef, Inject, Injectable } from '@nestjs/common';
+import { CACHE_MANAGER, Inject, Injectable } from '@nestjs/common';
 import { BigNumber as BigNumberJS } from 'bignumber.js';
 import { Cache } from 'cache-manager';
 import { ethers } from 'ethers';
@@ -17,15 +17,12 @@ import { BaseToken } from '~position/token.interface';
 import { PriceSelectorService } from '~token/selectors/token-price-selector.service';
 import { Network } from '~types/network.interface';
 
-import { AppToolkitHelperRegistry } from './app-toolkit.helpers';
 import { IAppToolkit } from './app-toolkit.interface';
 
 @Injectable()
 export class AppToolkit implements IAppToolkit {
   private readonly contractFactory: ContractFactory;
   constructor(
-    // We need the forward ref here, since there is a circular dependency on the AppToolkit, since each helper needs the toolkit
-    @Inject(forwardRef(() => AppToolkitHelperRegistry)) private readonly helperRegistry: AppToolkitHelperRegistry,
     @Inject(AppService) private readonly appService: AppService,
     @Inject(NetworkProviderService) private readonly networkProviderService: NetworkProviderService,
     @Inject(PositionService) private readonly positionService: PositionService,
@@ -112,12 +109,6 @@ export class AppToolkit implements IAppToolkit {
     await Promise.all(entries.map(([key, value]) => this.cacheManager.set(key, value, { ttl })));
   }
 
-  // Global Helpers
-
-  get helpers() {
-    return this.helperRegistry;
-  }
-
   getBigNumber(source: BigNumberJS.Value | ethers.BigNumber): BigNumberJS {
     if (source instanceof ethers.BigNumber) return new BigNumberJS(source.toString());
     return new BigNumberJS(source);