Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(goldfinch): Refactor logic and add claimable support #2138

Merged
merged 3 commits into from Jan 18, 2023

Conversation

gregegan
Copy link
Contributor

Description

  1. Rename incorrect filenames
  2. Add claimable fidu to Membership Vault
  3. Add claimable gfi support
  4. Simplify UI for user with many positions Staked (curve + fidu)

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@gregegan gregegan changed the title Refactor goldfinch logic and add claimable support [feature] Refactor goldfinch logic and add claimable support Jan 18, 2023
@gregegan gregegan changed the title [feature] Refactor goldfinch logic and add claimable support feat: Refactor goldfinch logic and add claimable support Jan 18, 2023
@@ -1,4 +1,15 @@
[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to the latest ABI and renamed the file

const balance = Number(balanceRaw);
if (balance === 0) return [];

const claimableGFI = await multicall.wrap(stakingRewardsContract).totalOptimisticClaimable(address);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section is new to support claimable gfi

balanceUSD: claimableGFIBalanceUSD,
};

let sumOfCurveTotalTokens = new BigNumber(0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also new, instead of showing 4 different positions - I am summing them up all into one.

Screenshot 2023-01-17 at 7 27 58 PM

@wpoulin
Copy link
Contributor

wpoulin commented Jan 18, 2023

Well done sir !!! Todos are crystal clear

For the step Validate Semantic PR to be ✅ , you will need to rename the PR to something like feat(goldfinch): Refactor logic and add claimables support

edit: I renamed the PR title, but you will also need to amen the previous commit message to match the title of the PR

@wpoulin wpoulin changed the title feat: Refactor goldfinch logic and add claimable support feat(goldfinch): Refactor goldfinch logic and add claimable support Jan 18, 2023
@wpoulin wpoulin changed the title feat(goldfinch): Refactor goldfinch logic and add claimable support feat(goldfinch): Refactor logic and add claimable support Jan 18, 2023
@wpoulin wpoulin merged commit 323f8a5 into Zapper-fi:main Jan 18, 2023
0xdapper pushed a commit to 0xdapper/studio that referenced this pull request Feb 28, 2023
…2138)

* feat(goldfinch): Refactor logic and add claimable support
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants