This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix: removed support for inactive games" #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetkosiso
changed the title
| @@ -16,7 +16,10 @@ const groupId = GOOD_GHOSTING_DEFINITION.groups.game.id; | |||
|
|
|||
| @Register.BalanceFetcher(GOOD_GHOSTING_DEFINITION.id, network) | |||
| export class CeloGoodGhostingBalanceFetcher implements BalanceFetcher { | |||
| constructor(@Inject(GoodGhostingBalanceFetcherHelper) private readonly helper: GoodGhostingBalanceFetcherHelper) {} | |||
| constructor( | |||
| @Inject(APP_TOOLKIT) private readonly appToolkit: IAppToolkit, | |||
There was a problem hiding this comment.
Remove unnecessary dependency, its not being used in this file.
| @@ -17,6 +21,9 @@ const networkId = NetworkId.CeloMainnet; | |||
| @Register.ContractPositionFetcher({ appId, groupId, network }) | |||
| export class CeloGoodGhostingGameContractPositionFetcher implements PositionFetcher<ContractPosition> { | |||
| constructor( | |||
| @Inject(APP_TOOLKIT) private readonly appToolkit: IAppToolkit, | |||
| @Inject(GoodGhostingContractFactory) private readonly goodGhostingContractFactory: GoodGhostingContractFactory, | |||
There was a problem hiding this comment.
Same comments, remove unnecessary dependencies.
immasandwich
approved these changes
Jun 30, 2022
jn-lp
added a commit
to Phuture-Finance/studio
that referenced
this pull request
Jul 5, 2022
* main: (172 commits) fix: disabled pool-together-v3's TVL (Zapper-fi#824) chore(main): release 0.101.0 (Zapper-fi#819) feat: add pool ratio to statsItem (Zapper-fi#825) fix: filtered out maple pool positions without liquidity (Zapper-fi#823) fix: removed prefix from coslend positions label (Zapper-fi#822) feat(qi-dao): add arbitrum support (Zapper-fi#821) fix: refactor aurora-plus's helper making it injectable (Zapper-fi#818) chore(main): release 0.100.3 (Zapper-fi#816) fix: add aurora plus logo (Zapper-fi#817) fix: solace fix addresses and style (Zapper-fi#815) fix(global): Roll API key chore(main): release 0.100.2 (Zapper-fi#813) fix(curve): Fix Curve label for cases with a single app token like ibEUR / sEUR chore(main): release 0.100.1 (Zapper-fi#810) fix(curve): Adjust Curve labels, show Yearn yield tokens in explore (Zapper-fi#812) fix(vvs-finance): update vvs-finance name definition (Zapper-fi#811) fix(yearn): Fix vault displayed APY (Zapper-fi#809) chore(main): release 0.100.0 (Zapper-fi#807) fix(good-ghosting): Removed support for inactive games (Zapper-fi#806) fix(rari-fuse): Add missing Arrakis Finance dependency (Zapper-fi#808) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
How to test?