From 6744ff1ca42f21ae434d905fbabaa8b744be957f Mon Sep 17 00:00:00 2001 From: Alfredo Garcia Date: Thu, 12 Oct 2023 16:20:02 -0300 Subject: [PATCH 1/3] allow clippy lint --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dd5ed921c..372a543b6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -154,4 +154,5 @@ jobs: - uses: actions-rs/cargo@v1 with: command: clippy - args: -- -D warnings + # TODO: remove the allowed lint when zcashd fiexes the code in zcash/src/rust/src/wallet.rs:540:14 + args: -- -D warnings -A clippy::unwrap_or_default From a1deb30a5683464dffba97f803fbf5b86ed21348 Mon Sep 17 00:00:00 2001 From: Conrado Gouvea Date: Mon, 16 Oct 2023 18:50:30 -0300 Subject: [PATCH 2/3] Revert "allow clippy lint" This reverts commit 6744ff1ca42f21ae434d905fbabaa8b744be957f. --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 372a543b6..dd5ed921c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -154,5 +154,4 @@ jobs: - uses: actions-rs/cargo@v1 with: command: clippy - # TODO: remove the allowed lint when zcashd fiexes the code in zcash/src/rust/src/wallet.rs:540:14 - args: -- -D warnings -A clippy::unwrap_or_default + args: -- -D warnings From afe724dbc7b7caf07671eae99a488a6746429ac1 Mon Sep 17 00:00:00 2001 From: Conrado Gouvea Date: Mon, 16 Oct 2023 18:51:11 -0300 Subject: [PATCH 3/3] move allow clippy rule to lib.rs --- src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib.rs b/src/lib.rs index 90b5f6b85..2bec6d226 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -9,6 +9,7 @@ #![allow(non_snake_case)] #![allow(unsafe_code)] #![allow(unused_imports)] +#![allow(clippy::unwrap_or_default)] // Use the generated C++ bindings include!(concat!(env!("OUT_DIR"), "/bindings.rs"));