From 99503ec01945ccd10098b490a41cc57428b35fec Mon Sep 17 00:00:00 2001
From: Gustavo Valverde <gustavo@iterativo.do>
Date: Tue, 17 Oct 2023 23:17:44 +0100
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Arya <aryasolhi@gmail.com>
---
 .github/workflows/cd-deploy-nodes-gcp.yml        | 10 +++++-----
 .github/workflows/ci-unit-tests-docker.patch.yml |  4 ++--
 .github/workflows/ci-unit-tests-docker.yml       |  6 +++---
 .github/workflows/ci-unit-tests-os.yml           |  1 -
 4 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/cd-deploy-nodes-gcp.yml b/.github/workflows/cd-deploy-nodes-gcp.yml
index b57aa37e94a..b3a20da0120 100644
--- a/.github/workflows/cd-deploy-nodes-gcp.yml
+++ b/.github/workflows/cd-deploy-nodes-gcp.yml
@@ -98,7 +98,7 @@ jobs:
 
   # Test that Zebra works using the default config with the latest Zebra version.
   test-configuration-file:
-    name: Test Zebra default Docker config file
+    name: Test CD default Docker config file
     needs: build
     uses: ./.github/workflows/sub-test-zebra-config.yml
     with:
@@ -107,9 +107,9 @@ jobs:
       test_variables: '-e NETWORK'
       network: 'Mainnet'
 
-  # Test reconfiguring the the docker image for tesnet.
+  # Test reconfiguring the docker image for testnet.
   test-configuration-file-testnet:
-    name: Test Zebra testnet Docker config file
+    name: Test CD testnet Docker config file
     needs: build
     # Make sure Zebra can sync the genesis block on testnet
     uses: ./.github/workflows/sub-test-zebra-config.yml
@@ -121,7 +121,7 @@ jobs:
 
   # Test that Zebra works using $ZEBRA_CONF_PATH config
   test-zebra-conf-path:
-    name: Test Zebra custom Docker config file
+    name: Test CD custom Docker config file
     needs: build
     uses: ./.github/workflows/sub-test-zebra-config.yml
     with:
@@ -150,7 +150,7 @@ jobs:
       matrix:
         network: [Mainnet, Testnet]
     name: Deploy ${{ matrix.network }} nodes
-    needs: [ build, versioning, test-configuration-file, test-configuration-file-testnet, test-zebra-conf-path ]
+    needs: [ build, versioning, test-configuration-file, test-zebra-conf-path ]
     runs-on: ubuntu-latest
     timeout-minutes: 60
     permissions:
diff --git a/.github/workflows/ci-unit-tests-docker.patch.yml b/.github/workflows/ci-unit-tests-docker.patch.yml
index 28f9e2cdd21..5a849f17ac9 100644
--- a/.github/workflows/ci-unit-tests-docker.patch.yml
+++ b/.github/workflows/ci-unit-tests-docker.patch.yml
@@ -70,13 +70,13 @@ jobs:
       - run: 'echo "No build required"'
 
   test-configuration-file:
-    name: Test Zebra default Docker config file
+    name: Test CI default Docker config file
     runs-on: ubuntu-latest
     steps:
       - run: 'echo "No build required"'
 
   test-zebra-conf-path:
-    name: Test Zebra custom Docker config file
+    name: Test CI custom Docker config file
     runs-on: ubuntu-latest
     steps:
       - run: 'echo "No build required"'
diff --git a/.github/workflows/ci-unit-tests-docker.yml b/.github/workflows/ci-unit-tests-docker.yml
index 8bbb18e33a7..176d395bc2a 100644
--- a/.github/workflows/ci-unit-tests-docker.yml
+++ b/.github/workflows/ci-unit-tests-docker.yml
@@ -209,7 +209,7 @@ jobs:
 
   # Test that Zebra works using the default config with the latest Zebra version.
   test-configuration-file:
-    name: Test default config file
+    name: Test CI default Docker config file
     needs: build
     uses: ./.github/workflows/sub-test-zebra-config.yml
     with:
@@ -220,7 +220,7 @@ jobs:
 
   # Test reconfiguring the the docker image for tesnet.
   test-configuration-file-testnet:
-    name: Test testnet config file
+    name: Test CI testnet Docker config file
     needs: build
     # Make sure Zebra can sync the genesis block on testnet
     uses: ./.github/workflows/sub-test-zebra-config.yml
@@ -233,7 +233,7 @@ jobs:
 
   # Test that Zebra works using $ZEBRA_CONF_PATH config
   test-zebra-conf-path:
-    name: Test custom config file
+    name: Test CI custom Docker config file
     needs: build
     uses: ./.github/workflows/sub-test-zebra-config.yml
     with:
diff --git a/.github/workflows/ci-unit-tests-os.yml b/.github/workflows/ci-unit-tests-os.yml
index 710c522daf1..00594afacd5 100644
--- a/.github/workflows/ci-unit-tests-os.yml
+++ b/.github/workflows/ci-unit-tests-os.yml
@@ -30,7 +30,6 @@ on:
       - '**/clippy.toml'
       # workflow definitions
       - '.github/workflows/ci-unit-tests-os.yml'
-      - '.github/workflows/sub-build-docker-image.yml'
 
   push:
     branches: