Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RedJubjub types in zebra-chain. #142

Merged
merged 1 commit into from Dec 12, 2019
Merged

Use RedJubjub types in zebra-chain. #142

merged 1 commit into from Dec 12, 2019

Conversation

@hdevalence
Copy link
Member

hdevalence commented Dec 10, 2019

Ticks one box off of #123

Closes #125.

@hdevalence hdevalence requested a review from ZcashFoundation/zebra-team Dec 10, 2019
Copy link
Member

dconnolly left a comment

❤️

///
/// XXX refine to a specific type.
pub rk: [u8; 32],
pub rk: redjubjub::PublicKeyBytes<SpendAuth>,

This comment has been minimized.

Copy link
@dconnolly
/// XXX refine to a specific type: redjubjub signature?
/// XXX for now it's [u64; 8] instead of [u8; 64] to get trait impls
pub spend_auth_sig: [u64; 8],
pub spend_auth_sig: redjubjub::Signature<SpendAuth>,

This comment has been minimized.

Copy link
@dconnolly
// XXX refine this type to a RedJubjub signature.
// for now it's [u64; 8] rather than [u8; 64] to get trait impls
pub binding_sig: [u64; 8],
pub binding_sig: redjubjub::Signature<Binding>,

This comment has been minimized.

Copy link
@dconnolly
@dconnolly dconnolly merged commit 4315235 into main Dec 12, 2019
1 check passed
1 check passed
Google Cloud Build Google Cloud Build
Details
@dconnolly dconnolly deleted the use-redjubjub branch Dec 12, 2019
@dconnolly dconnolly added this to In progress in 🦓 via automation Dec 12, 2019
@dconnolly dconnolly moved this from In progress to Done in 🦓 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
🦓
  
Done
2 participants
You can’t perform that action at this time.