Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio, futures, hyper to released versions. #145

Merged
merged 1 commit into from Dec 13, 2019
Merged

Conversation

@hdevalence
Copy link
Member

hdevalence commented Dec 13, 2019

Closes #117

@@ -649,7 +650,7 @@ mod tests {
let services = PeerServices::NODE_NETWORK;
let timestamp = Utc.timestamp(1568000000, 0);

let rt = Runtime::new().unwrap();
let mut rt = Runtime::new().unwrap();

This comment has been minimized.

Copy link
@hdevalence

hdevalence Dec 13, 2019

Author Member

The tokio runtime doesn't use interior mutability any more so it has to be mutable to spawn tasks.

tower = "=0.3.0-alpha.2"
tower-load = { git = "https://github.com/tower-rs/tower", branch = "v0.3.x"}
tower = { git = "https://github.com/tower-rs/tower" }
tower-load = { git = "https://github.com/tower-rs/tower" }

This comment has been minimized.

Copy link
@hdevalence

hdevalence Dec 13, 2019

Author Member

Better to just take the git version of tower until 0.3.0 is finished.

use tokio::{codec::Framed, net::TcpStream, prelude::*, timer::Interval};
use futures::{channel::mpsc, prelude::*};
use tokio::net::TcpStream;
use tokio_util::codec::Framed;

This comment has been minimized.

Copy link
@hdevalence

hdevalence Dec 13, 2019

Author Member

Tokio codec functionality has moved to tokio_util.

@dconnolly dconnolly added this to In progress in 🦓 via automation Dec 13, 2019
Copy link
Member

dconnolly left a comment

LGTM!

🦓 automation moved this from In progress to Reviewer approved Dec 13, 2019
@dconnolly dconnolly merged commit 2965187 into main Dec 13, 2019
1 check passed
1 check passed
Google Cloud Build Google Cloud Build
Details
🦓 automation moved this from Reviewer approved to Done Dec 13, 2019
@dconnolly dconnolly deleted the update-tokio branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
🦓
  
Done
2 participants
You can’t perform that action at this time.