Skip to content

CI: Add workflow that runs zizmor latest - #9110

Merged
gustavovalverde merged 1 commit into
ZcashFoundation:mainfrom
str4d:ci-zizmor
Mar 31, 2025
Merged

CI: Add workflow that runs zizmor latest#9110
gustavovalverde merged 1 commit into
ZcashFoundation:mainfrom
str4d:ci-zizmor

Conversation

@str4d

@str4d str4d commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Source: zizmorcore/zizmor@c6fef48

Motivation

This repository has many GitHub Actions workflows. zizmor is a static analysis tool that can find many common security issues in typical GitHub Actions CI/CD setups, such as the recent Ultralytics workflow vulnerability.

Follow-up Work

zizmor identifies a bunch of problems. I'll open a separate PR to fix the ones I can see how to fix. Nope, there are way too many workflows for me to fix in the time I have available.

@str4d
str4d requested a review from a team as a code owner January 9, 2025 21:37
@str4d
str4d requested review from arya2 and removed request for a team January 9, 2025 21:37
@github-actions github-actions Bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 9, 2025
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@arya2 arya2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice find and thank you for the PR.

Nope, there are way too many workflows for me to fix in the time I have available.

Yep. I tried doing the same. Luckily the vulnerabilities I've seen so far all seem okay until CI is opened up. We may want to ignore the template-injection rule and others to fix the lints one by one.

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance labels Jan 9, 2025
@arya2
arya2 requested a review from gustavovalverde January 10, 2025 21:13
@mpguerra

Copy link
Copy Markdown
Contributor

@mergify refresh

@mergify

mergify Bot commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Feb 3, 2025
@gustavovalverde

Copy link
Copy Markdown
Member

@mergify rebase

@mergify

mergify Bot commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@48ab28a6f5dbc2a99bf1e0131198dd8f1df78169 # v3.28.0

Check failure

Code scanning / zizmor

GHSA-vqf5-2xx6-9wfm

GHSA-vqf5-2xx6-9wfm
@mergify

mergify Bot commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #9110 has been dequeued. The pull request rule doesn't match anymore

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@gustavovalverde

Copy link
Copy Markdown
Member

@Mergifyio requeue

@mergify

mergify Bot commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@gustavovalverde
gustavovalverde enabled auto-merge (squash) March 31, 2025 13:04
@gustavovalverde
gustavovalverde merged commit 81c2cc4 into ZcashFoundation:main Mar 31, 2025
aphelionz pushed a commit to ShieldedLabs/zebra-crosslink-staging that referenced this pull request Apr 2, 2025
aphelionz pushed a commit to ShieldedLabs/zebra-crosslink-staging that referenced this pull request Apr 2, 2025
@upbqdn upbqdn mentioned this pull request Apr 30, 2025
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants