Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective disclosure #47

Open
rex4539 opened this issue Nov 13, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@rex4539
Copy link
Contributor

commented Nov 13, 2018

It would be nice if there was support for selective disclosure.

https://z.cash/blog/viewing-keys-selective-disclosure
https://github.com/zcash/zcash/blob/master/doc/payment-disclosure.md

This is, of course, an experimental feature but it's a good opportunity to test it out and figure out the UI/UX.

Since it's still experimental and requires special flags to be passed to zcashd or zcash.conf you could enable this functionality (for now) only if those flags are already passed to zcashd or zcash.conf before starting zec-qt-wallet.

@rex4539

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2018

@adityapk00

This comment has been minimized.

Copy link
Collaborator

commented Nov 15, 2018

This is interesting, and I'd love to add this. Reading @garethtdavies's medium post, the parsing of the debug.log to get the params is the difficult bit I can see here. Do you folks know if there's work in progress in zcashd to get these params in an easier way?

@garethtdavies

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2018

Did you see the response here saying that wasn't actually too hard (I've never tried this myself) https://medium.com/@peter.gavin.stewart/thanks-for-the-write-up-helped-a-lot-with-the-api-building-59f08f3b6b50

This is worth a read https://github.com/zcash/zips/blob/5ef71b0325c552748334144576daea918497ec4b/drafts/bitcartel-payment-disclosure/draft.rst#known-issues a lot of the known issues are Sprout related as they relate to JoinSplits and I am unaware of how this all works with Sapling. So might be worth getting an update on progress/plans for this before digging in much more (I do love the idea of this being usable though).

@adityapk00

This comment has been minimized.

Copy link
Collaborator

commented Nov 21, 2018

So I've been playing around with this, and looks like payment disclosure doesn't work for sapling addresses? Is that what you guys are seeing too?

@garethtdavies

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

Looking at the debug.log file for Sprout txs things get added via Payment Disclosure: Successfully added entry to database.... For Sapling there is nothing so I guess it doesn't work as you have found and get Transaction is not a shielded transaction trying to generate one. As with most things post-Sapling I get a feeling things can be greatly improved but we'll need to wait.

@rex4539

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

Perhaps @bitcartel could chime in?

@the-metalworker

This comment has been minimized.

Copy link

commented Dec 7, 2018

The viewing keys feature of the Zcash protocol is very interesting. I would like to see full support for this feature in the wallet so I can export view keys for my own transactions, as well as import view keys to see the details of other users' transactions.

@adityapk00

This comment has been minimized.

Copy link
Collaborator

commented Dec 7, 2018

Update: I looked into this, and the support for viewing keys and selective disclosure is not complete in zcashd for sapling addresses. It currently only works for sprout addresses.

So, the current plan is to wait for sapling support for selective disclosure (which is coming soon, I believe), and then make it work in zec-qt-wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.