Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically load controllers #23

Conversation

velveteenrobot
Copy link
Contributor

When a requested controller is not in the list of default controllers, the controller manager will check for the controller on the parameter server. The controller loader now also catches pluginlib exceptions from trying to load a bad controller instead of crashing the controller manager.

trying_to_load_bad_controller

@@ -254,7 +254,7 @@ void ControllerManager::execute(const robot_controllers_msgs::QueryControllerSta
robot_controllers_msgs::ControllerState state = goal->updates[i];

// Make sure controller exists
bool exists = false;
bool in_default_controllers = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably leave this as "exists" or "in_controller_list" -- technically, once you load your new controller, the "controllers_" list actually consists not just of the default controllers, but also of everything you have loaded since startup

@velveteenrobot
Copy link
Contributor Author

Okay probably better now. I hope.

@mikeferguson mikeferguson merged commit 358174e into ZebraDevs:indigo-devel Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants