Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS? #12

Open
treasuretron opened this issue May 10, 2020 · 5 comments
Open

RSS? #12

treasuretron opened this issue May 10, 2020 · 5 comments

Comments

@treasuretron
Copy link

cool tool! Seems like maybe not in active development anymore but it's going to work well for me! :) So thank you!

But, curious if you're thinking of adding basic rss.xml generation. If not, I can take a swing at it.

@Zedelghem
Copy link
Owner

Hey,

thanks! It was enough for me as it was but I'm happy to add a reasonable feature at request. RSS feeds are a good idea, give me a few days and they will be in.

Best,
B.

@Zedelghem
Copy link
Owner

Zedelghem commented May 21, 2020

An option to add the RSS feed is on and tweakable from the configuration file. Take a look at it!
Just to see if it works, run build.py and head to site/rss.xml which should be there, automatically generated. (Make sure you have rfeed installed beforehand.)

@treasuretron
Copy link
Author

woohoo!! thanks so much for adding RSS functionality!

Curious why did you get rid of the out_folder option? I had made some tweaks to pystatic.py to meet my needs so I merged your RSS changes in but keeping the out_folder option. Seems to work!

seems like a fairly valid rss :)
https://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fteafry.me%2Frss

awesome!

@Zedelghem
Copy link
Owner

Zedelghem commented May 25, 2020

Oh, you're right, there's no out_folder option. I had been toying with the idea of removing it at some point because I honestly couldn't think of a reason why would one need it. It must had happened then. But recently I started to contemplate publishing pystatic as a PyPI module and it would make sense to have that option in for that purpose. I'll put it back in in a few days. Sorry for the inconvenience.

I'll try to make the RSS a bit more valid. I can see some room for improvement with the guid, for instance.

Cheers!

PS: Actually, it seems that most of the issues can be solved by adding the http:// or https:// to the $blog_domain variable in the config file. The only problem that remains is that the language code is in a wrong format. I'll look into it.

@treasuretron
Copy link
Author

it's no problem. Not sure if this is the best way to set this up but my directory structure is:

├── README.md
├── build.py
├── lib
├── posts
├── public_html
│   ├── about
│   │   └── index.html
│   ├── blog
│   │   ├── assets
│   │   │   └── porch.jpg
│   │   ├── css
│   │   ├── index.html
│   │   ├── lib
│   │   └── posts
│   │       ├── 2018-03-14_test_page.html
│   │       ├── 2020-05-10_actual_post_1.html
│   │       ├── 2020-05-15_I_think_this_works.html
│   │       └── 2020-05-19_notes_on_the_blog.html
│   ├── index.html
│   ├── rss
│   ├── style.css
├── pystatic.cfg
├── pystatic.py
├── rfeed.py
└── templates

so I have it put the blog stuff into public_html/blog. Also I disabled copying over style.css and just reference the main style.css for the whole site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants