joystick deadzone #257
Merged
joystick deadzone #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the PR will have to be rebased for CI to pass. I've also retargeted the PR to a branch since there are a few more changes to make for keyboard/controller navigation to work correctly with this new option, so I'll take care of those in the branch once it's merged. |
|
I may be having some issues with the rebase. Just to make sure I understood correctly, I need to rebase to feat/analog-cam, right? Because I didn't even do that yet. Those checks were triggered after I clicked on the sync fork button. |
|
Thanks for the contribution! |
Mr-Wiseguy
pushed a commit
that referenced
this pull request
May 26, 2024
Mr-Wiseguy
pushed a commit
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple deadzone applied to each axis separately. The deadzone is essentially a box. The value of each axis is re-scaled so it's 0 at the deadzone and 1 at the end of travel.
I think ideally the deadzone should be a circle. I tried that but I realized my controller would be maxed out on one axis and still output a non-zero value on another, so I couldn't use trig to compute the proper deadzone values for each axis. And this will likely change from controller to controller, so I think for this to work properly it'd be necessary to have something similar to Dolphin's deadzone thingamajig.