Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic save backup system #260

Merged
merged 2 commits into from
May 26, 2024
Merged

Automatic save backup system #260

merged 2 commits into from
May 26, 2024

Conversation

Reonu
Copy link
Collaborator

@Reonu Reonu commented May 25, 2024

When saving the game, it will be saved to a temp file, then the current save will be renamed to be a backup, and the temp file is then renamed to be the actual file. This prevents save corruption.

Making it a draft PR so you can also add the error message when the save can't be written before merging.

@Mr-Wiseguy Mr-Wiseguy marked this pull request as ready for review May 26, 2024 15:38
@Mr-Wiseguy Mr-Wiseguy merged commit 4ebe71b into dev May 26, 2024
5 checks passed
@Mr-Wiseguy Mr-Wiseguy deleted the save_backup branch May 26, 2024 15:42
AngheloAlf added a commit to N64Recomp/N64ModernRuntime that referenced this pull request Jun 1, 2024
From Zelda64Recomp/Zelda64Recomp#260 commit 4ebe71bfccbef17268c8941bed8d428d445268ca

Co-authored-by: Reonu <danileon95@gmail.com>
Co-authored-by: Mr-Wiseguy <mrwiseguyromhacking@gmail.com>
AngheloAlf pushed a commit to N64Recomp/N64ModernRuntime that referenced this pull request Jun 1, 2024
From Zelda64Recomp/Zelda64Recomp#260 commit 4ebe71bfccbef17268c8941bed8d428d445268ca

Co-authored-by: Mr-Wiseguy <mrwiseguyromhacking@gmail.com>
AngheloAlf pushed a commit to N64Recomp/N64ModernRuntime that referenced this pull request Jun 1, 2024
From Zelda64Recomp/Zelda64Recomp#260 commit 4ebe71bfccbef17268c8941bed8d428d445268ca

Co-authored-by: Mr-Wiseguy <mrwiseguyromhacking@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants