Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main volume option to settings #267

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

jpburnett
Copy link
Contributor

This commit adds the option to control the main volume game via a slider added to the "Sound" tab in the settings menu.

Aims to address #207

assets/config_menu/sound.rml Outdated Show resolved Hide resolved
src/game/recomp_api.cpp Outdated Show resolved Hide resolved
patches/sound.h Outdated Show resolved Hide resolved
Fixed nav menuing, and removed recomp APIs.
Copy link
Member

@Mr-Wiseguy Mr-Wiseguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now and it works great, thanks!

@Mr-Wiseguy Mr-Wiseguy merged commit 1691559 into Zelda64Recomp:dev May 26, 2024
5 checks passed
@jpburnett jpburnett deleted the vol-main branch May 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants