New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With playwright #85
With playwright #85
Conversation
|
I think that there is a problem with the chrome version dixit some comments available here: https://stackoverflow.com/questions/45631715/downloading-with-chrome-headless-and-selenium |
|
Playwright depends on CDP functionality that is only available in Chromium 84. So either you need to build Chromium from source (84 stable release date is somewhere in July), or patch the Playwright code. |
|
Hi @Niek 👋 Thanks for the news. 👌 I don't think I got the time to investigate the build of Chrome at the moment... 😅 |
|
I tried patching Playwright but the changes are too severe to work around it (e.g. major changes around the browser contexts). I think the best bet would be to get a beta Chromium build working based on https://git.alpinelinux.org/aports/tree/community/chromium/APKBUILD |
|
Hi @Niek I'm ok with this idea 💡 But... for your information, the compilation takes 1,5 days if I quote to this comment #28 (comment) And we can't add this feature using the Docker Hub for the compilation. In this comment, we can see the current limits here
|
|
Yes the builds are crazy slow. I have opened a MR for chromium 83 (latest stable): https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/8463 If that goes well I'll try to create a chromium-beta aport. |
|
Chromium 83 is now in aports: https://git.alpinelinux.org/aports/commit/?id=0400e89dfb72eeadb513a46934b9bfdc258df2d0 Playwright 1.0+ needs Chromium 84+, but in my tests the 83 build seems to work fine. So I think this PR can be merged :) Edit: recent Firefox builds also have CDP support built-in now, so theoretically you can also use Playwright with FF on Alpine. |
awesome, excited about that |
|
Hi @Niek and @lucmichalski 👋 I will check that now! Thanks for the info! 🙌 |
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* ✨ play with deno 🦕 * ✏️ end of file
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
@all-contributors please add @Niek for question and ideas |
|
I've put up a pull request to add @Niek! 🎉 |
|
Please share the announcement: https://twitter.com/jlandure/status/1268175622230233091 |
At the moment, this is the result: