More usable change administrator password model #934

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@javierag
Contributor

javierag commented Jan 31, 2014

No description provided.

unless (defined ($newpwd1) and defined ($newpwd2)) {
throw EBox::Exceptions::DataMissing(data => __('New password'));
}
unless ($newpwd1 eq $newpwd2) {
- throw EBox::Exceptions::External(__('New passwords do not match.'));
+ throw EBox::Exceptions::External(__('Passwords does not match.'));

This comment has been minimized.

Show comment Hide comment
@sixstone-qq

sixstone-qq Feb 1, 2014

Contributor

Typo: Passwords do not match.

@sixstone-qq

sixstone-qq Feb 1, 2014

Contributor

Typo: Passwords do not match.

- throw EBox::Exceptions::External(__('Incorrect current password.'));
+ my $userIsAdmin = grep { $_ eq $username } @{ _adminUsers() };
+ if (not $userIsAdmin) {
+ throw EBox::Exceptions::External(__x("The user {us} is not a administrator user", us => $username));

This comment has been minimized.

Show comment Hide comment
@sixstone-qq

sixstone-qq Feb 1, 2014

Contributor

Typo: is not an administrator user

@sixstone-qq

sixstone-qq Feb 1, 2014

Contributor

Typo: is not an administrator user

@chris18890

This comment has been minimized.

Show comment Hide comment
@chris18890

chris18890 Feb 1, 2014

If I'm reading this right, does this change effectively mean the user no longer has to enter their current password to set a new password? If so, I disagree with that...

If I'm reading this right, does this change effectively mean the user no longer has to enter their current password to set a new password? If so, I disagree with that...

@javierag

This comment has been minimized.

Show comment Hide comment
@javierag

javierag Feb 4, 2014

Contributor

Hello Chris,

is standard that the administrator user can change password without entering/knowing them, even if its it own password. (This page can also be sued to change the password of other administrator)

Contributor

javierag commented Feb 4, 2014

Hello Chris,

is standard that the administrator user can change password without entering/knowing them, even if its it own password. (This page can also be sued to change the password of other administrator)

Merge branch '3.2' into sysadmin-change-passwd
Conflicts:
	main/core/ChangeLog
@jacalvo

This comment has been minimized.

Show comment Hide comment
@jacalvo

jacalvo Mar 13, 2014

Member

We may probably improve the usability of this for 3.5, but for 3.2 this is rejected.

Member

jacalvo commented Mar 13, 2014

We may probably improve the usability of this for 3.5, but for 3.2 this is rejected.

@jacalvo jacalvo closed this Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment