Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo credits, description for hourly updates missing #11

Closed
Efreak opened this issue Jan 30, 2018 · 1 comment
Closed

Photo credits, description for hourly updates missing #11

Efreak opened this issue Jan 30, 2018 · 1 comment

Comments

@Efreak
Copy link

Efreak commented Jan 30, 2018

The in-app photo credits link doesn't do anything when tapped; it doesn't even highlight. I was thinking that maybe it's missing href or formatted placeholder, but a look at the source shows that's not true, so I'm not sure what's happening there. There should probably at least be a link to the file on the GitHub description, as the alternative is digging through the repo to find it.

Also, there's no description anywhere of what exactly the hourly updates does, either in the app or in GitHub.

@Zer0xFF
Copy link
Owner

Zer0xFF commented Jan 30, 2018

Hi Efreak,
I thought the hourly update was self evident I didn't bother explaining it,
simply put, the morning picture will change on an hourly pace instead of it being set 1 time it's set at the start of the morning.. and thats true for the afternoon, evening and night time.

I've had a quick look at the app and you're right the photo credit link it's working correctly, if I had to guess, the textview above it, is extending down, prevent the click, once I get the chance, I'll confirm and fix it, thanks.

@Efreak Efreak closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants