Fix unit_carrier_drone crash & issues with incorrect drone type if carrier is morphed #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of unit_morph.lua call unit_carrier_drones.lua to inform about morph, unit_carrier_drones.lua will wait for UnitDestroyed() event (like Jump gadget do) to check for morph. The reason for this change is because previous method require back-and-forth communication, while in later method unit_carrier_drones.lua only check morph info from unit_morph.lua once. Later method felt more self-contained.
…carrier, then it might have unexpected type of drone". This is because, when a carrier (especially a commander) morph into another carrier, the gadget will just copy paste drone_definition of old carrier into new carrier. This meant the drone_definition designed for the new carrier will be lost.
Histidine91
added a commit
that referenced
this pull request
Jul 26, 2014
Fix unit_carrier_drone crash & issues with incorrect drone type if carrier is morphed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit first fix unit_carrier_drones.lua crashing if commander finish morphing while drone is building,
Then fixed a case where... if a carrier morph into another carrier with different drone_def , then the new drone_def will be overwritten by old carrier's drone_def. This mean, if Funnelweb morph into Armcarry, then Armcarry will be building battledrone and not seagull and the emit point will be wrong.
The fix is split into 3 commit for readability/better-history since this is a PR for 3 different tweak/fix at once.