Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to Haldis #141

Merged
merged 6 commits into from Sep 9, 2019

Conversation

@Jan-PieterBaert
Copy link
Member

commented Sep 8, 2019

This fixes #139

@redfast00

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Thank you! Could you add some instructions on how to verify that types are correct when adding new code? Maybe also add a typechecker to the CI (don't know if this is feasible).

@Jan-PieterBaert

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

I will have a look at it tomorrow to add to the readme or some other file.
The check should be done using mypy with the argument --ignore-missing-imports if it says modules cannot be found.

@Jan-PieterBaert

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

@redfast00 I have added a file which lists tests which need to be run, I will let @mcbloch handle the CI

@redfast00 redfast00 merged commit 32c60ea into master Sep 9, 2019
@redfast00 redfast00 deleted the typing branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.