Tests for each functionality

[xgleich1]

First of all a big thanks for your work on this lib, it looks really helpful!

Bit I am hesitant to use it since there are almost no tests in this project (the simple one in the sample project is not enough) and thus no way to verify that your code works as intendet.

This would also serve as a great way to showcase your complete api.

[Zhuinden]

Completely agree! Lot of the code is based on agoda/kakao, but tests would be nice nonetheless 👍

[Zhuinden]

Completely agree! Lot of the code is based on agoda/kakao, but tests would be nice nonetheless 👍

[aumarbello]

Interested in taking this up, but could explain the nature of the tests that should be written?

[aumarbello]

Interested in taking this up, but could explain the nature of the tests that should be written?

[Zhuinden]

@aumarbello technically there are a bunch of assertion types that start with check___, technically this block of code

For example, for checkContainsText, you'd need a text view that has a given text, and you would need to verify that if the TextView contains the right text then there is no assertion error, but if the TextView contains the wrong text then an assertion error is thrown.

This would be required for each check___ assertion type, but just adding any of such tests would be helpful.

Evidently, this would have to be done in instrumentation test.

[Zhuinden]

@aumarbello technically there are a bunch of assertion types that start with check___, technically this block of code

For example, for checkContainsText, you'd need a text view that has a given text, and you would need to verify that if the TextView contains the right text then there is no assertion error, but if the TextView contains the wrong text then an assertion error is thrown.

This would be required for each check___ assertion type, but just adding any of such tests would be helpful.

Evidently, this would have to be done in instrumentation test.

[aumarbello]

Okay, so for example if I want to test all the assertions that have to do with texts I will need an activity with TextView and in the activity's instrumentation test after using the assertions, verify the behavior (happy and sad path) of the assertions I used right?

[aumarbello]

Okay, so for example if I want to test all the assertions that have to do with texts I will need an activity with TextView and in the activity's instrumentation test after using the assertions, verify the behavior (happy and sad path) of the assertions I used right?

[Zhuinden]

Yep!

[Zhuinden]

Yep!

[aumarbello]

Okay, would love to work on the full suites of tests but would it be okay to do so gradually?

[aumarbello]

Okay, would love to work on the full suites of tests but would it be okay to do so gradually?

[Zhuinden]

I mean, it'd be crazy if I expected immediate 100% completion, I'm already glad someone volunteers for any of it in the first place.

Totally ok to do it gradually, of course. Happy to have help in general. 😄

[Zhuinden]

I mean, it'd be crazy if I expected immediate 100% completion, I'm already glad someone volunteers for any of it in the first place.

Totally ok to do it gradually, of course. Happy to have help in general. 😄

[aumarbello]

Okay, would get started on it.

[aumarbello]

Okay, would get started on it.