Skip to content

Conversation

@Uthedris
Copy link
Contributor

Fixes:

  • riscv32_common.zig is_pending function need a compare to return a bool.
  • hazard3.zig interrupt priority registers were incorrect.
  • hazard3.zig removed an interrupt enable that tact1m4n3 didn't like.

@Grazfather Grazfather requested a review from tact1m4n3 May 24, 2025 18:17
Copy link
Collaborator

@tact1m4n3 tact1m4n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Don't know why I used meifa to set priorities 😆. Also, some riscv examples are broken, please change the examples using external interrupts to enable the MachineExternal interrupt on riscv.

@Uthedris
Copy link
Contributor Author

I updated the interrupt example. The only other examples I found that used interrupts were RP2040 only, so don't need riscv support.

@mattnite mattnite merged commit b4adc72 into ZigEmbeddedGroup:main May 26, 2025
43 checks passed
@Uthedris Uthedris deleted the riscv-isr branch May 26, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants