Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Include Guard Check #1657

Merged
merged 6 commits into from May 13, 2019

Conversation

@KaustubhShamshery
Copy link
Collaborator

commented May 10, 2019

Description

Standardize header guards.

Reference : https://google.github.io/styleguide/cppguide.html#The__define_Guard

  • For our case, it is ZILLIQA_<path_to_file>_H_

  • to generate header guard put,

#ifndef A_H_ 
#define A_H_
....
.... 
#endif  // A_H_

and run ./scripts/replace_header_guard.py and the statements will be replaced by correct header guard

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • Check License
  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@KaustubhShamshery KaustubhShamshery changed the title Feature/include guard check Standardize Include Guard Check May 10, 2019
@KaustubhShamshery KaustubhShamshery self-assigned this May 10, 2019
@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #1657 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
- Coverage   33.75%   33.62%   -0.13%     
==========================================
  Files         270      270              
  Lines       32850    33294     +444     
==========================================
+ Hits        11087    11195     +108     
- Misses      21763    22099     +336
Impacted Files Coverage Δ
src/libConsensus/ConsensusLeader.h 0% <ø> (ø) ⬆️
src/libDirectoryService/DirectoryService.h 0% <ø> (ø) ⬆️
src/libData/BlockData/BlockHeader/DSBlockHeader.h 6.25% <ø> (ø) ⬆️
src/libUtils/TimeLockedFunction.h 100% <ø> (ø) ⬆️
src/libData/BlockData/Block/VCBlock.h 20% <ø> (ø) ⬆️
src/libUtils/IPConverter.h 100% <ø> (ø) ⬆️
src/libUtils/DataConversion.h 71.87% <ø> (ø) ⬆️
src/libData/BlockData/BlockHeader/TxBlockHeader.h 7.14% <ø> (ø) ⬆️
src/libData/AccountData/TxnPool.h 2.73% <ø> (ø) ⬆️
src/libServer/Server.h 0% <ø> (ø) ⬆️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd64e2...1d2f7de. Read the comment docs.

@KaustubhShamshery KaustubhShamshery added Ready and removed in-progress labels May 12, 2019
@KaustubhShamshery KaustubhShamshery marked this pull request as ready for review May 12, 2019
@KaustubhShamshery KaustubhShamshery added on hold and removed Ready labels May 13, 2019
@ansnunez ansnunez added this to PRs in development in Core via automation May 13, 2019
@KaustubhShamshery KaustubhShamshery force-pushed the feature/include_guard_check branch from e7c1ecd to b04b605 May 13, 2019
@KaustubhShamshery KaustubhShamshery added Ready and removed on hold labels May 13, 2019
Core automation moved this from PRs in development to PRs approved - ready to merge! May 13, 2019
@KaustubhShamshery KaustubhShamshery requested a review from Gnnng May 13, 2019
Core automation moved this from PRs approved - ready to merge! to PRs needing review (please help!) May 13, 2019
.travis.yml Outdated Show resolved Hide resolved
@KaustubhShamshery KaustubhShamshery requested a review from Gnnng May 13, 2019
@Gnnng
Gnnng approved these changes May 13, 2019
Copy link
Member

left a comment

LGTM

Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! May 13, 2019
@bb111189 bb111189 merged commit 6197ee8 into master May 13, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) May 13, 2019
@Gnnng Gnnng deleted the feature/include_guard_check branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
6 participants
You can’t perform that action at this time.