Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pedantic flag to compiler options #1659

Merged
merged 2 commits into from May 13, 2019

Conversation

@KaustubhShamshery
Copy link
Collaborator

commented May 10, 2019

Description

Build Zilliqa with -pedantic

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@KaustubhShamshery KaustubhShamshery requested review from Gnnng and ansnunez May 10, 2019
@KaustubhShamshery KaustubhShamshery self-assigned this May 10, 2019
@KaustubhShamshery KaustubhShamshery added this to PRs in development in Core via automation May 10, 2019
@KaustubhShamshery KaustubhShamshery changed the title Add pedantic flag to compile Add pedantic flag to compiler options May 10, 2019
@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #1659 into master will increase coverage by 0.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage   33.74%   33.75%   +0.01%     
==========================================
  Files         270      270              
  Lines       32847    32850       +3     
==========================================
+ Hits        11084    11090       +6     
+ Misses      21763    21760       -3
Impacted Files Coverage Δ
...rc/libData/BlockData/BlockHeader/VCBlockHeader.cpp 59.09% <ø> (ø) ⬆️
src/libServer/LookupServer.cpp 0.11% <ø> (ø) ⬆️
src/libUtils/Logger.cpp 79.2% <ø> (ø) ⬆️
src/libUtils/RootComputation.cpp 74.28% <ø> (ø) ⬆️
src/libServer/LookupServer.h 0% <0%> (ø) ⬆️
src/libServer/Server.cpp 0% <0%> (ø) ⬆️
src/libData/BlockChainData/BlockLinkChain.cpp 85.45% <100%> (ø) ⬆️
src/libUtils/SWInfo.cpp 93.12% <100%> (ø) ⬆️
tests/Data/Test_EIP.cpp 100% <100%> (ø) ⬆️
tests/POW/test_POW.cpp 84.6% <100%> (+0.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e952c6e...9f1c8e5. Read the comment docs.

@KaustubhShamshery KaustubhShamshery force-pushed the feature/add_compile_options branch from 1a702d1 to 9f1c8e5 May 10, 2019
@Gnnng
Gnnng approved these changes May 11, 2019
Copy link
Member

left a comment

Thanks.

Core automation moved this from PRs in development to PRs approved - ready to merge! May 11, 2019
@KaustubhShamshery KaustubhShamshery added on hold and removed on hold labels May 12, 2019
@ansnunez ansnunez merged commit 7cd64e2 into master May 13, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) May 13, 2019
@Gnnng Gnnng deleted the feature/add_compile_options branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
5 participants
You can’t perform that action at this time.