Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop lookup api server when it is synchronizing #1677

Merged
merged 3 commits into from Jun 3, 2019

Conversation

@ShengguangXiao
Copy link
Contributor

commented May 29, 2019

Description

Stop lookup api server when it is synchronizing

Zilliqa/Issues#519

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@ShengguangXiao ShengguangXiao requested review from KaustubhShamshery and sandipbhoir and removed request for KaustubhShamshery May 29, 2019
@ShengguangXiao ShengguangXiao self-assigned this May 29, 2019
@ShengguangXiao ShengguangXiao added this to PRs in development in Core via automation May 29, 2019
@ShengguangXiao ShengguangXiao moved this from PRs in development to PRs needing review (please help!) in Core May 29, 2019
@@ -3118,6 +3125,9 @@ void Lookup::RejoinAsNewLookup() {

LOG_MARKER();
if (m_mediator.m_lookup->GetSyncType() == SyncType::NO_SYNC) {
m_lookupServer->StopListening();
LOG_GENERAL(INFO, "API Server stopped listen for syncing");

This comment has been minimized.

Copy link
@chitowncrispy

chitowncrispy May 29, 2019

Would "API Server stopped listening to sync client" be more descriptive?

Copy link
Collaborator

left a comment

} else if (LOOKUP_NODE_MODE && m_syncType == SyncType::NEW_LOOKUP_SYNC) {
add the logic to re-enable here too.

@codecov-io

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #1677 into master will decrease coverage by 0.44%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1677      +/-   ##
==========================================
- Coverage   33.63%   33.18%   -0.45%     
==========================================
  Files         270      270              
  Lines       32988    33630     +642     
==========================================
+ Hits        11094    11161      +67     
- Misses      21894    22469     +575
Impacted Files Coverage Δ
src/libLookup/Lookup.cpp 4.72% <0%> (-0.03%) ⬇️
src/libZilliqa/Zilliqa.cpp 4.16% <0%> (-0.03%) ⬇️
src/libLookup/Lookup.h 0% <0%> (ø) ⬆️
src/common/Constants.h 100% <0%> (ø) ⬆️
src/libPersistence/Retriever.cpp 0% <0%> (ø) ⬆️
src/libUtils/SWInfo.cpp 90.83% <0%> (ø) ⬆️
src/common/Constants.cpp 99.78% <0%> (+0.03%) ⬆️
src/libNode/Node.cpp 0.69% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b2471...2f3f09d. Read the comment docs.

Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! May 30, 2019
@ansnunez ansnunez merged commit 147b74e into master Jun 3, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jun 3, 2019
@ShengguangXiao ShengguangXiao deleted the fix/lookup_server branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
6 participants
You can’t perform that action at this time.