Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch constant file from dsguard instead of normal node #1679

Merged
merged 1 commit into from May 31, 2019

Conversation

@ckyang
Copy link
Contributor

commented May 29, 2019

Description

release.sh will fetch constant files from running testnet. For dsguard/normal nodes, currently we fetch from normal-0. It would be safer to fetch from dsguard-0 instead of normal-0, especially now normal-0 ~ normal-179 are not available anymore.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@ckyang ckyang self-assigned this May 29, 2019
@ckyang ckyang added bug Ready labels May 29, 2019
@ckyang ckyang requested review from ansnunez and ShengguangXiao May 29, 2019
@ckyang ckyang added this to PRs in development in Core via automation May 29, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core May 29, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! May 29, 2019
@codecov-io

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

Merging #1679 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   33.63%   33.62%   -0.01%     
==========================================
  Files         270      270              
  Lines       32988    32988              
==========================================
- Hits        11094    11093       -1     
- Misses      21894    21895       +1
Impacted Files Coverage Δ
src/libUtils/SWInfo.cpp 90.07% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b2471...0fe2482. Read the comment docs.

@chitowncrispy

This comment has been minimized.

Copy link

commented May 29, 2019

What is the difference between copying from a dsguard node and a normal node?

@ansnunez ansnunez merged commit e29ad28 into master May 31, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) May 31, 2019
@Gnnng Gnnng deleted the fix/releasenormal branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
5 participants
You can’t perform that action at this time.