Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IP check on VC #1690

Merged
merged 4 commits into from Jun 18, 2019

Conversation

@kaikawaliu
Copy link
Contributor

commented Jun 13, 2019

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@kaikawaliu kaikawaliu added the Untested label Jun 13, 2019
@kaikawaliu kaikawaliu self-assigned this Jun 13, 2019
@kaikawaliu kaikawaliu added this to PRs in development in Core via automation Jun 13, 2019
@kaikawaliu kaikawaliu requested review from bb111189 and ansnunez Jun 13, 2019
@kaikawaliu kaikawaliu force-pushed the fix/removevcipcheck branch from bfda84a to 2afd338 Jun 14, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #1690 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
- Coverage   33.57%   33.41%   -0.17%     
==========================================
  Files         270      270              
  Lines       33002    33604     +602     
==========================================
+ Hits        11080    11228     +148     
- Misses      21922    22376     +454
Impacted Files Coverage Δ
src/libNode/ViewChangeBlockProcessing.cpp 0% <0%> (ø) ⬆️
...rc/libDirectoryService/ViewChangePreProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/DSBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/Node.cpp 0.86% <0%> (+0.22%) ⬆️
src/libLookup/Lookup.cpp 5.14% <0%> (+0.41%) ⬆️
src/libUtils/SWInfo.cpp 93.12% <0%> (+2.29%) ⬆️
src/libPersistence/BlockStorage.cpp 34.76% <0%> (+6.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7cda6...ff22c3e. Read the comment docs.

@kaikawaliu kaikawaliu added Ready and removed Untested labels Jun 14, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Jun 17, 2019
@ansnunez

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@kaikawaliu looks like txn-sanity-check.py was unintentionally added in your PR?

break;
}
++indexToLeader;
// if (m_mediator.m_DSCommittee->at(candidateLeaderIndex).second !=

This comment has been minimized.

Copy link
@ansnunez

ansnunez Jun 17, 2019

Contributor

Can just completely remove this commented out code block

// Used range based loop due to clang tidy enforcement
list<PubKey> localCumulativeFaultyLeadersPubKey;
for (const auto& node : m_cumulativeFaultyLeaders) {
localCumulativeFaultyLeadersPubKey.push_back(node.first);

This comment has been minimized.

Copy link
@ansnunez

ansnunez Jun 17, 2019

Contributor

emplace_back for efficiency


list<PubKey> proposedCumulativeFaultyLeadersPubKey;
for (const auto& node : m_pendingVCBlock->GetHeader().GetFaultyLeaders()) {
proposedCumulativeFaultyLeadersPubKey.push_back(node.first);

This comment has been minimized.

Copy link
@ansnunez

ansnunez Jun 17, 2019

Contributor

emplace_back for efficiency

Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jun 17, 2019
@ansnunez ansnunez merged commit c2f3ad2 into master Jun 18, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
4 participants
You can’t perform that action at this time.