Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for txn hash #1692

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@kaikawaliu
Copy link
Contributor

commented Jun 14, 2019

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@kaikawaliu kaikawaliu added the Ready label Jun 14, 2019
@kaikawaliu kaikawaliu self-assigned this Jun 14, 2019
@kaikawaliu kaikawaliu added this to PRs in development in Core via automation Jun 14, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #1692 into master will increase coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   33.57%   33.58%   +<.01%     
==========================================
  Files         270      270              
  Lines       33002    33005       +3     
==========================================
+ Hits        11080    11084       +4     
+ Misses      21922    21921       -1
Impacted Files Coverage Δ
src/libNode/Node.cpp 0.63% <0%> (-0.01%) ⬇️
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libLookup/Lookup.cpp 4.77% <100%> (+0.04%) ⬆️
src/libUtils/SWInfo.cpp 93.12% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7cda6...8150f42. Read the comment docs.

@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Jun 17, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jun 17, 2019
@ansnunez ansnunez merged commit 6cab0c8 into master Jun 17, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
4 participants
You can’t perform that action at this time.