Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node only do sync if failed to do pow #1707

Merged
merged 1 commit into from Jul 4, 2019

Conversation

@ShengguangXiao
Copy link
Contributor

commented Jun 26, 2019

Description

Node only do sync if failed to do pow, previous it will download all the persistence from S3 which is redundant and when the block height is big, it takes long time to download persistence and give big pressure to S3.

Zilliqa/Issues#532

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@codecov-io

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #1707 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   33.54%   33.54%   -0.01%     
==========================================
  Files         270      270              
  Lines       33071    33073       +2     
==========================================
  Hits        11095    11095              
- Misses      21976    21978       +2
Impacted Files Coverage Δ
src/libNode/PoWProcessing.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a4528...5ff7782. Read the comment docs.

@ShengguangXiao ShengguangXiao force-pushed the fix/pow_fail_rejoin branch from ceb6020 to 5ff7782 Jun 27, 2019
@ShengguangXiao ShengguangXiao requested review from ckyang, bb111189, KaustubhShamshery and sandipbhoir and removed request for ckyang Jun 28, 2019
@ShengguangXiao ShengguangXiao added this to PRs in development in Core via automation Jun 28, 2019
@ShengguangXiao ShengguangXiao moved this from PRs in development to PRs needing review (please help!) in Core Jun 28, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jul 4, 2019
@ansnunez ansnunez merged commit 5002ee1 into master Jul 4, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 4, 2019
@ShengguangXiao ShengguangXiao deleted the fix/pow_fail_rejoin branch Jul 8, 2019
@ShengguangXiao ShengguangXiao restored the fix/pow_fail_rejoin branch Jul 8, 2019
@ShengguangXiao ShengguangXiao deleted the fix/pow_fail_rejoin branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
4 participants
You can’t perform that action at this time.