Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epochfin for lookup when no shard formed #1709

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@kaikawaliu
Copy link
Contributor

commented Jul 1, 2019

Description

Let the lookup put epochfin during non-vacuous epoch if no microblock is loaded from finalblock.
For fixing issue of PutEpochFin didn't get triggered when no shard is formed:
Zilliqa/Issues#535

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@kaikawaliu kaikawaliu added the Ready label Jul 1, 2019
@kaikawaliu kaikawaliu requested review from ansnunez and sandipbhoir Jul 1, 2019
@kaikawaliu kaikawaliu self-assigned this Jul 1, 2019
@kaikawaliu kaikawaliu added this to PRs in development in Core via automation Jul 1, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #1709 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
- Coverage   33.54%   33.54%   -0.01%     
==========================================
  Files         270      270              
  Lines       33071    33073       +2     
==========================================
  Hits        11095    11095              
- Misses      21976    21978       +2
Impacted Files Coverage Δ
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a4528...35f8e7e. Read the comment docs.

@kaikawaliu kaikawaliu force-pushed the fix/epochfin0shard branch from 35f8e7e to 3a65086 Jul 1, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Jul 1, 2019
@ansnunez

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@kaikawaliu any similar fix needed here?

if (!LOOKUP_NODE_MODE) {

@ansnunez

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@kaikawaliu any similar fix needed here?

if (!LOOKUP_NODE_MODE) {

After discussion with @kaikawaliu he says no change is needed here or elsewhere

Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jul 5, 2019
@ansnunez ansnunez merged commit 758e240 into master Jul 5, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
5 participants
You can’t perform that action at this time.