Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log popen failure #1712

Merged
merged 1 commit into from Jul 4, 2019

Conversation

@sandipbhoir
Copy link
Contributor

commented Jul 2, 2019

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@sandipbhoir sandipbhoir self-assigned this Jul 2, 2019
@sandipbhoir sandipbhoir added this to PRs in development in Core via automation Jul 2, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #1712 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
+ Coverage   33.54%   33.55%   +<.01%     
==========================================
  Files         270      270              
  Lines       33071    33069       -2     
==========================================
  Hits        11095    11095              
+ Misses      21976    21974       -2
Impacted Files Coverage Δ
src/libUtils/SysCommand.h 18.18% <0%> (ø) ⬆️
src/libNode/Node.cpp 0.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b96ea...8599a23. Read the comment docs.

@sandipbhoir sandipbhoir requested a review from kaikawaliu Jul 2, 2019
@sandipbhoir sandipbhoir added the Ready label Jul 2, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Jul 3, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jul 4, 2019
@ansnunez ansnunez merged commit 838f1dc into master Jul 4, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
4 participants
You can’t perform that action at this time.