Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of kubectl cp command #1713

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@ckyang
Copy link
Contributor

commented Jul 2, 2019

Description

A quick fix for kubectl cp ... command, missing the file name in target path.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@ckyang ckyang requested review from Gnnng and ShengguangXiao Jul 2, 2019
@ckyang ckyang self-assigned this Jul 2, 2019
@ckyang ckyang added bug Ready labels Jul 2, 2019
@ckyang ckyang added this to PRs in development in Core via automation Jul 2, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #1713 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   33.54%   33.54%           
=======================================
  Files         270      270           
  Lines       33071    33071           
=======================================
  Hits        11095    11095           
  Misses      21976    21976

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b96ea...58b41d1. Read the comment docs.

@Gnnng
Gnnng approved these changes Jul 2, 2019
Core automation moved this from PRs in development to PRs approved - ready to merge! Jul 2, 2019
@ansnunez ansnunez merged commit c588c9a into master Jul 3, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
6 participants
You can’t perform that action at this time.