Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether account exists when create contract #1714

Merged
merged 1 commit into from Jul 4, 2019

Conversation

@kaikawaliu
Copy link
Contributor

commented Jul 3, 2019

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@kaikawaliu kaikawaliu added the Ready label Jul 3, 2019
@kaikawaliu kaikawaliu self-assigned this Jul 3, 2019
@kaikawaliu kaikawaliu added this to PRs in development in Core via automation Jul 3, 2019
Core automation moved this from PRs in development to PRs approved - ready to merge! Jul 3, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #1714 into master will decrease coverage by 0.23%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
- Coverage   33.58%   33.34%   -0.24%     
==========================================
  Files         270      270              
  Lines       33035    33329     +294     
==========================================
+ Hits        11095    11115      +20     
- Misses      21940    22214     +274
Impacted Files Coverage Δ
src/libData/AccountData/AccountStoreBase.h 100% <ø> (ø) ⬆️
src/libData/AccountData/AccountStoreSC.tpp 4.27% <0%> (-0.02%) ⬇️
src/libData/AccountData/AccountStoreBase.tpp 42.85% <83.33%> (+0.31%) ⬆️
src/libNetwork/P2PComm.cpp 5.36% <0%> (+0.28%) ⬆️
src/libUtils/SWInfo.cpp 93.12% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c588c9a...4552a53. Read the comment docs.

@ansnunez ansnunez merged commit 8145466 into master Jul 4, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
6 participants
You can’t perform that action at this time.