Contract map storage & Scilla IPC #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of the server in https://github.com/Zilliqa/ipc-experiment. The unit tests have been disabled and need to be added thoroughly later.
Create ScillaIPCServer
Gnnng
reviewed
Sep 5, 2019
Gnnng
reviewed
Sep 5, 2019
Gnnng
reviewed
Sep 5, 2019
vaivaswatha
reviewed
Sep 5, 2019
ansnunez
approved these changes
Sep 5, 2019
ansnunez
requested review from
sandipbhoir,
ShengguangXiao,
bb111189 and
Gnnng
Gnnng
approved these changes
Sep 5, 2019
sandipbhoir
approved these changes
Sep 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
=========================================
- Coverage 33.75% 31.45% -2.3%
=========================================
Files 274 278 +4
Lines 33750 36435 +2685
=========================================
+ Hits 11391 11460 +69
- Misses 22359 24975 +2616
Continue to review full report at Codecov.
|
ShengguangXiao
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduced a new contract storage method for the need of large map updating in contract. At meantime, a new way of interaction between scilla binaries from blockchain perspective via IPC communication.
Breaking change happens for the account and contract storage related data structure and JSON API contract states.
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)