New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client pop-up error management #77

Merged
merged 9 commits into from Nov 10, 2018

Conversation

@ZimGil
Owner

ZimGil commented Nov 8, 2018

The client is now capable of managing "POP-UP" errors

tooltip errors will still be part of the template for now.
We could change them to pop-up at any time.

resolves #76

@ZimGil ZimGil added this to the Beta Release milestone Nov 8, 2018

@ZimGil ZimGil self-assigned this Nov 8, 2018

@ZimGil ZimGil requested a review from ortichon Nov 8, 2018

Show resolved Hide resolved src/app/services/error/error.service.ts Outdated
Show resolved Hide resolved src/app/models/pop-up-error.interface.ts Outdated
Show resolved Hide resolved src/app/services/error/error.service.ts Outdated
Show resolved Hide resolved src/app/app.component.ts Outdated
Show resolved Hide resolved src/app/app.component.ts Outdated

ZimGil added some commits Nov 9, 2018

@ZimGil ZimGil referenced this pull request Nov 10, 2018

Closed

Avoid double subscriptions #78

@ZimGil ZimGil changed the title from client error management to client pop-up error management Nov 10, 2018

Show resolved Hide resolved src/app/app.component.ts Outdated
Show resolved Hide resolved src/app/models/pop-up-error.interface.ts Outdated

@ZimGil ZimGil force-pushed the #76-client-error-management branch from d797e7b to 1c826ea Nov 10, 2018

@ZimGil ZimGil merged commit aeffc59 into master Nov 10, 2018

1 check passed

Hound No violations found. Woof!

@ZimGil ZimGil deleted the #76-client-error-management branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment