Prevent span.help-inline around signup errors #55

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

mikedfunk commented Apr 1, 2013

In the login view an error looks like this:
<div class="alert alert-error">Incorrect username, email or password.</div>
In the register view it looks like this:
<div class="alert alert-error"><span class="help-inline">The email field is required.</span></div>
This was making my errors look weird.

This pull removes any default error wrappers to be more consistent with how the Login form displays error text.

Prevent span.help-inline around signup errors
In the login view it returns a string in ```Session::get('error')``` but in register it returns an array populated from validation. In Laravel 4 this wraps with ```<span class="help-inline"></span>```. This was making my ```div.alert``` look weird.

This pull removes any default error wrappers to be more consistent with how the Login form receives error text.

andrew13 added a commit that referenced this pull request Apr 1, 2013

Merge pull request #55 from mikedfunk/patch-2
Prevent span.help-inline around signup errors. Thanks @mikedfunk

@andrew13 andrew13 merged commit 2b9955d into Zizaco:master Apr 1, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment