Skip to content

Add quest: Land of the Goblins #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 2, 2022
Merged

Add quest: Land of the Goblins #845

merged 6 commits into from
Jul 2, 2022

Conversation

christianlegge
Copy link
Contributor

Added quest Land of the Goblins. I tested as I was playing but haven't been able to do a full runthrough after finishing the implementation.

KNOWN ISSUES:

  • Didn't catch the exact coords in the Yu'biusk instance at the end and you can't return to the instance after the quest, so I'll need someone's help to fix that. Might be "good enough" as is, but I just estimated.

OTHER CHANGES:

  • There's a point in this quest where you have to accept your goblin name, and the dialog box isn't the same every time. I added regex support to WidgetChoiceStep to account for this.
  • Added GREATER and LESS operations to Operation.java for use in conditionals, varbit reqs, etc.

Zoinkwiz
Zoinkwiz approved these changes Jul 2, 2022
View reviewed changes
Copy link
Owner

@Zoinkwiz Zoinkwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 😄

@Zoinkwiz Zoinkwiz merged commit 2f50bf6 into Zoinkwiz:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoinkwiz Zoinkwiz Zoinkwiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianlegge @Zoinkwiz