Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify Solidity version for SOLIDITY_G2_ADDITION_LIB #475

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@fulldecent
Copy link
Contributor

fulldecent commented Sep 24, 2019

This makes the code safer if it will be used separately from the other code

@JacobEberhardt

This comment has been minimized.

Copy link
Member

JacobEberhardt commented Sep 24, 2019

Thanks for the suggestion! Would be great if you could have the PR target develop instead of master. The default is a bit unfortunate, here.

@fulldecent fulldecent force-pushed the fulldecent:patch-7 branch from 687f92a to d4e3047 Oct 2, 2019
@fulldecent fulldecent changed the base branch from master to develop Oct 2, 2019
@fulldecent

This comment has been minimized.

Copy link
Contributor Author

fulldecent commented Oct 2, 2019

Got it, merge base updated.

@fulldecent

This comment has been minimized.

Copy link
Contributor Author

fulldecent commented Jan 6, 2020

Please see that build error is not related to this change

@Schaeff
Schaeff approved these changes Jan 7, 2020
Copy link
Member

Schaeff left a comment

Thanks!

@Schaeff Schaeff merged commit ebb22b8 into Zokrates:develop Jan 7, 2020
4 of 5 checks passed
4 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: wasm_test Your tests passed on CircleCI!
Details
@fulldecent fulldecent deleted the fulldecent:patch-7 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.