Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes macos installation issues as per: https://github.com/scipr… #530

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@Genysys
Copy link

Genysys commented Dec 6, 2019

…-lab/libsnark/issues/86

Please try this out on other targets to ensure that the omission of SuperCop doesn't break anything

@Schaeff

This comment has been minimized.

Copy link
Member

Schaeff commented Dec 6, 2019

Thanks it's a good start. I think for this to be even more useful we should have complete instructions about requirements on macos, namely openssl and how to install it reliably.

@Schaeff Schaeff changed the base branch from master to develop Dec 6, 2019
@Schaeff Schaeff changed the base branch from develop to master Dec 6, 2019
@Schaeff Schaeff changed the base branch from master to develop Dec 6, 2019
@Genysys

This comment has been minimized.

Copy link
Author

Genysys commented Dec 6, 2019

Where do you think is best to add this? In the README.md or the documentation? I would say documentation under HERE as the README.md is nice and sweet and makes no references to the additional backends

@Schaeff

This comment has been minimized.

Copy link
Member

Schaeff commented Dec 9, 2019

Yes I suggest this section should be updated to remove the Linux disclaimer, and instructions for boost and openssl (and anything else needed) should be added here by adding a Prerequisites section with instructions for Ubuntu and MacOS

@Schaeff
Schaeff approved these changes Jan 9, 2020
Copy link
Member

Schaeff left a comment

LGTM, I'll add instructions in another PR

@Schaeff Schaeff merged commit 0726752 into Zokrates:develop Jan 9, 2020
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: wasm_test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.