Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to solidity 0.6.1 #545

Merged
merged 2 commits into from Jan 9, 2020
Merged

Upgrade to solidity 0.6.1 #545

merged 2 commits into from Jan 9, 2020

Conversation

@Schaeff
Copy link
Member

Schaeff commented Jan 9, 2020

No description provided.

@leekt216

This comment has been minimized.

Copy link

leekt216 commented Jan 9, 2020

I think it's better to just use ABIEncoderV2 version and remove non-ABIEncoderV2 version. Since it's not experimental anymore from 0.6. https://github.com/ethereum/solidity/releases/tag/v0.6.0
Code will be a lot simpler in that way.

@Schaeff

This comment has been minimized.

Copy link
Member Author

Schaeff commented Jan 9, 2020

Yeah I was hesitant to do that. The pragma statement is still required though, that's why I left the v1 ABI version too

@Schaeff Schaeff requested a review from JacobEberhardt Jan 9, 2020
Copy link
Member

JacobEberhardt left a comment

Good to go, thanks :)

@JacobEberhardt JacobEberhardt merged commit 1a7bab1 into develop Jan 9, 2020
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@JacobEberhardt JacobEberhardt deleted the upgrade-to-solidity-06 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.