Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libsnark by default #546

Open
wants to merge 19 commits into
base: develop
from
Open

Enable libsnark by default #546

wants to merge 19 commits into from

Conversation

@Schaeff
Copy link
Member

Schaeff commented Jan 9, 2020

  • Add instructions for MacOS
  • Remove WITH_LIBSNARK distinction
@@ -31,6 +31,40 @@ cargo +nightly build --release
cd target/release
```

If you want to enable the libsnark backend in ZoKrates, you need to install some prerequisites:

This comment has been minimized.

Copy link
@JacobEberhardt

JacobEberhardt Jan 10, 2020

Member

This sounds optional, but since this PR enables libsnark compilation by default, we should probably mark these dependencies as mandatory? Alternatively, we could explicitly document how to build without libsnark, here.

This comment has been minimized.

Copy link
@JacobEberhardt

JacobEberhardt Jan 10, 2020

Member

Furthermore, specifying minimum versions we tested with could be helpful. Not mandatory.

This comment has been minimized.

Copy link
@Schaeff

Schaeff Jan 13, 2020

Author Member

If we're confident enough that MacOS works, it would even make sense to remove the part about building without libsnark entirely? Or maybe it's still useful for other OS?

This comment has been minimized.

Copy link
@JacobEberhardt

JacobEberhardt Jan 13, 2020

Member

good point, that sounds optimal. only need to document the optional "without-libsnark" build, then.

Schaeff added 16 commits Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.