Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import context #565

Merged
merged 13 commits into from Feb 17, 2020
Merged

Fix import context #565

merged 13 commits into from Feb 17, 2020

Conversation

@Schaeff
Copy link
Member

Schaeff commented Feb 13, 2020

Imports aren't processed correctly in some cases involving different files having the same relative paths: one file ends up overwriting the other when resolving imports, which leads to a semantic-time panic.

Add test.
Fix this.

Also, since semantic checks happen on the whole tree rather than a single file, errors found in dependencies were wrongly linked back to the entry point file. Fix this.

Copy link
Member

JacobEberhardt left a comment

Good to go.

@Schaeff Schaeff merged commit cf8600e into develop Feb 17, 2020
6 checks passed
6 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: wasm_test Your tests passed on CircleCI!
Details
ci/circleci: zokrates_js_build Your tests passed on CircleCI!
Details
ci/circleci: zokrates_js_test Your tests passed on CircleCI!
Details
@Schaeff Schaeff deleted the fix-import-context branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.