From 946095948ab593a5314dc4be1426c4d1f2fcebb4 Mon Sep 17 00:00:00 2001 From: Juan Leni Date: Fri, 27 Feb 2026 21:33:00 +0100 Subject: [PATCH] fix: decouple container usage from runner label The container and setup-ubuntu-packages conditions were hardcoded to only activate when runs_on == 'zondax-runners'. This prevented other runner labels (e.g. kunobi-runners) from using the Docker container, causing jobs to fail with missing tools (cargo, node, etc). Replace the runner label check with runner_preset != 'macos-arm64', which correctly enables containers for all Linux runners regardless of their label. Affected workflows: - _checks-rs.yaml - _checks-ts.yaml - _checks-links.yaml --- .github/workflows/_checks-links.yaml | 4 ++-- .github/workflows/_checks-rs.yaml | 4 ++-- .github/workflows/_checks-ts.yaml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/_checks-links.yaml b/.github/workflows/_checks-links.yaml index b61eb06..fedc995 100644 --- a/.github/workflows/_checks-links.yaml +++ b/.github/workflows/_checks-links.yaml @@ -74,7 +74,7 @@ on: jobs: link-check: runs-on: ${{ fromJSON(inputs.runner_preset == 'macos-arm64' && '["self-hosted", "macOS", "ARM64"]' || format('["{0}"]', inputs.runs_on)) }} - container: ${{ inputs.runs_on == 'zondax-runners' && inputs.base_image || '' }} + container: ${{ inputs.runner_preset != 'macos-arm64' && inputs.base_image || '' }} timeout-minutes: ${{ inputs.timeout_minutes }} environment: ${{ inputs.environment }} permissions: @@ -84,7 +84,7 @@ jobs: steps: - name: Setup Ubuntu packages # Skip when using zondax/ubuntu-ci (packages pre-installed, but sudo available if needed) - if: inputs.runs_on == 'zondax-runners' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') + if: inputs.runner_preset != 'macos-arm64' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') uses: zondax/actions/setup-ubuntu-packages@v1 with: packages: | diff --git a/.github/workflows/_checks-rs.yaml b/.github/workflows/_checks-rs.yaml index b72be1a..7d6bfa2 100644 --- a/.github/workflows/_checks-rs.yaml +++ b/.github/workflows/_checks-rs.yaml @@ -193,7 +193,7 @@ permissions: jobs: checks-rust: runs-on: ${{ fromJSON(inputs.runner_preset == 'macos-arm64' && '["self-hosted", "macOS", "ARM64"]' || format('["{0}"]', inputs.runs_on)) }} - container: ${{ inputs.runner_preset != 'macos-arm64' && inputs.runs_on == 'zondax-runners' && inputs.base_image || '' }} + container: ${{ inputs.runner_preset != 'macos-arm64' && inputs.base_image || '' }} timeout-minutes: ${{ inputs.timeout_minutes }} environment: ${{ inputs.environment }} env: @@ -214,7 +214,7 @@ jobs: steps: - name: Setup Ubuntu packages # Skip when using zondax/ubuntu-ci (packages pre-installed, but sudo available if needed) - if: inputs.runs_on == 'zondax-runners' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') + if: inputs.runner_preset != 'macos-arm64' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') uses: zondax/actions/setup-ubuntu-packages@v1 with: packages: | diff --git a/.github/workflows/_checks-ts.yaml b/.github/workflows/_checks-ts.yaml index 45302d8..5fb9553 100644 --- a/.github/workflows/_checks-ts.yaml +++ b/.github/workflows/_checks-ts.yaml @@ -157,7 +157,7 @@ on: jobs: checks-ts: runs-on: ${{ fromJSON(inputs.runner_preset == 'macos-arm64' && '["self-hosted", "macOS", "ARM64"]' || format('["{0}"]', inputs.runs_on)) }} - container: ${{ inputs.runner_preset != 'macos-arm64' && inputs.runs_on == 'zondax-runners' && inputs.base_image || '' }} + container: ${{ inputs.runner_preset != 'macos-arm64' && inputs.base_image || '' }} timeout-minutes: ${{ inputs.timeout_minutes }} environment: ${{ inputs.environment }} permissions: @@ -168,7 +168,7 @@ jobs: steps: - name: Setup Ubuntu packages # Skip when using zondax/ubuntu-ci (packages pre-installed, but sudo available if needed) - if: inputs.runs_on == 'zondax-runners' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') + if: inputs.runner_preset != 'macos-arm64' && !startsWith(inputs.base_image, 'zondax/ubuntu-ci') uses: zondax/actions/setup-ubuntu-packages@v1 with: packages: |