Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

migrated hardhat #213

Merged
merged 8 commits into from
Feb 10, 2023
Merged

migrated hardhat #213

merged 8 commits into from
Feb 10, 2023

Conversation

Pfed-prog
Copy link
Contributor

@Pfed-prog Pfed-prog commented Feb 6, 2023

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2023

CLA assistant check
All committers have signed the CLA.

@emmanuelm41
Copy link
Member

emmanuelm41 commented Feb 8, 2023

@Pfed-prog there is an issue with running tests for external contributor. We asked GitHub about it. As soon as they fix it, we will trigger tests and merge it if they pass! Hold on there please!

@emmanuelm41
Copy link
Member

@Pfed-prog could you set the hardhat private key so it has some account with funds to run the hardhat tests? That should be enough to merge the PR.

@Pfed-prog
Copy link
Contributor Author

Pfed-prog commented Feb 10, 2023

@Pfed-prog could you set the hardhat private key so it has some account with funds to run the hardhat tests? That should be enough to merge the PR.

I am not really sure where to store the private key, should i change something in my repository GitHub environment or hard code variable in .env file directly

@emmanuelm41
Copy link
Member

@Pfed-prog could you set the hardhat private key so it has some account with funds to run the hardhat tests? That should be enough to merge the PR.

I am not really sure where to store the private key, should i change something in my repository GitHub environment or hard code variable in .env file directly

You should add it here (under your forked repo config)
image

@Pfed-prog
Copy link
Contributor Author

Pfed-prog commented Feb 10, 2023

Added a private_key and transferred 5 TFIL via faucet
image
@emmanuelm41

@emmanuelm41
Copy link
Member

@Pfed-prog please, re run the CI and it should work!

@Pfed-prog
Copy link
Contributor Author

@Pfed-prog please, re run the CI and it should work!

I apologize I am not sure how to accomplish this

@emmanuelm41
Copy link
Member

@Pfed-prog please, re run the CI and it should work!

I apologize I am not sure how to accomplish this

A new commit on the PR please!

@Pfed-prog
Copy link
Contributor Author

It fails once again, maybe i need to add it into an environment

@emmanuelm41
Copy link
Member

It fails once again, maybe i need to add it into an environment

It should be something like this "0746ce973d40a0f89c72xxxxxxxxxxxx2f95fc7e" (32 bytes long, 64 hex string)

@Pfed-prog
Copy link
Contributor Author

Sure, added "57cb47da57d864f5f1b0de38c7e4a2ab12ede9d8b4bd???68966da0dcdbc7309", but with this commit added ""

@Pfed-prog
Copy link
Contributor Author

checked the history of commits once again i think without "" actually passed
image

@emmanuelm41 emmanuelm41 merged commit fab5466 into Zondax:master Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants