sql injection and session fixation vulerability fixes #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kylejohnson
commented
Feb 4, 2017
kylejohnson
commented
- SQL injection is addressed by sanitizing inputs and using real prepared statements (not emulating them).
- Session fixation is addressed by regenerating the session id after a successful log in.
On successful login, tell php to regenerate the session id
set http_only flag in cookie settings
This makes sure the statement and the values aren't parsed by PHP before sending it to the MySQL server. See https://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php and https://secure.php.net/manual/en/pdo.setattribute.php
Tell PDO to use real prepared statements.
Log xss fixes2
Sanitize input parameters
|
This was previously approved in the Pro fork. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.