Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs reference specific PHP version and file location on Ubuntu/Debian Installation instructions regarding the PHP config file #2375

Closed
SalmonMode opened this issue Jan 1, 2019 · 4 comments
Closed

Docs reference specific PHP version and file location on Ubuntu/Debian Installation instructions regarding the PHP config file #2375

SalmonMode opened this issue Jan 1, 2019 · 4 comments
Labels
Documentation

Comments

@SalmonMode
Copy link
Contributor

SalmonMode commented Jan 1, 2019 •
edited

I noticed in the docs here and here, that in step 9 it references a specific version of PHP and a specific location for the php config file, but some might not have that version of PHP, or their PHP may be loading a different config file.

This might throw some people off, so to help them (in addition to having more correct and thorough documentation), this step in the documentation should also describe how to find the config file that PHP will actually be loading.
@welcome
Copy link

welcome bot commented Jan 1, 2019

Thanks for opening your first issue here! Just a reminder, this forum is for Bug Reports only. Be sure to follow the issue template!

@SalmonMode SalmonMode changed the title Docs reference specific PHP version and file location on Ubuntu Installation instructions regarding the PHP config file Docs reference specific PHP version and file location on Ubuntu/Debian Installation instructions regarding the PHP config file Jan 1, 2019
@SalmonMode SalmonMode mentioned this issue Jan 1, 2019
Merged
@knight-of-ni
Copy link
Member

From the context of your message I am guessing you are running Ubuntu 18.04. Notice the documentation you referenced is for Ubuntu 16.04.

The version of php is tied to the version of the linux distro it ships with. Centos 7 ships with php 5.4, fedora 29 php 7.2, ubuntu 16.04 php 7.0, ubuntu 18.04 php 7.2, etc. These typically do not change by the software manufacturer because the chance to cause breakage is significant.

The path to the php.ini file is correct for an Ubuntu 16.04 system. That's not to say we should not update the documentation at all. However what should be done, instead, is a new set of installation installation instructions written specifically for Ubuntu 18.04.

@SalmonMode
Copy link
Contributor Author

Yeah, you're correct. That was the version of Ubuntu I was working with. I'll modify my PR to just add a new section for 18.04 later today.

@SalmonMode
Copy link
Contributor Author

Fixed up the PR 👍

connortechnology pushed a commit that referenced this issue Feb 12, 2019
@SalmonMode @connortechnology
Fixes #2375 (#2376)
f7b31c8 
* updated docs to include instructions on how to find the loaded PHP config file

* Added note about verifying timezone change

* revert docs back to master branch's content

* added installation guide for Ubuntu 18.04

The only difference between Ubuntu 16.04 and 18.04 is the version of
PHP that comes installed, which changes the location of its config file

* reverting debian instructions to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnoorenberghe @knight-of-ni @SalmonMode